Opened 9 months ago

Closed 5 months ago

#5491 closed enhancement (complete)

Create unit tests for duplicated comment / user context

Reported by: fdupont Owned by: fdupon
Priority: low Milestone: Kea1.4
Component: configuration Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Subtickets

Change History (7)

comment:1 Changed 9 months ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 9 months ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Build a positive and a few negative tests for DHCPv4, copied them to DHCPv6, D2 and CA.
BTW I fixed the cut & paste bug for D2 comment tests (note it had no impact as not embedded comments are pure lexical stuff).
Ready for review.

comment:3 Changed 8 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4

comment:4 Changed 5 months ago by tmark

  • Owner changed from UnAssigned to tmark

comment:5 follow-up: Changed 5 months ago by tmark

  • Owner changed from tmark to fdupon

The changes seem fine, builds and passes unit tests on Ubuntu 16.04.

However I could not find any discussion in the admin guide about duplicate "comment" entries. Since one may apparently only have a single "comment" per scope that should be be stated somewhere in the documentation.

comment:6 in reply to: ↑ 5 Changed 5 months ago by fdupont

Replying to tmark:

The changes seem fine, builds and passes unit tests on Ubuntu 16.04.

However I could not find any discussion in the admin guide about duplicate "comment" entries. Since one may apparently only have a single "comment" per scope that should be be stated somewhere in the documentation.

=> it is true for any entry, not only for comment, but as there was a discussion about allowing (i.e. making an exception) multiple comments I found useful to explicitly test it. Note the code with multiple comments and smart collect of them was not public so IMHO we don't need to add something in the documentation...

comment:7 Changed 5 months ago by fdupont

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged. Closing.

Note: See TracTickets for help on using tickets.