Opened 3 months ago

Last modified 4 weeks ago

#5450 reviewing defect

flex_id tests includes the module

Reported by: fdupont Owned by: UnAssigned
Priority: low Milestone: Kea1.4-final
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no


It is incorrect and gives warnings like:

  CXXLD    flex_id_unittests

*** Warning: Linking the executable flex_id_unittests against the loadable module
*** is not portable!
*** Warning: lib is a module, not a shared library

I propose to fix the makefile and to check if tests still pass.


Change History (4)

comment:1 Changed 3 months ago by fdupont

  • Milestone changed from Kea-proposed to Kea1.4-final

comment:2 Changed 3 months ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

I have a current work on premium so I'll check if it still works when fixed.

comment:3 Changed 3 months ago by fdupont

Replacing the .so by the convenience archive (*) it continues to work and no longer raise a warning.
(*) the fact some tests use hook codes outside the hook mechanism (i.e. load DSO) is arguable but it is another issue.

Included in trac5420 in 9693e6a13a..9db57ed9d8.

comment:4 Changed 4 weeks ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Branch created for premium submodule.
Ready for review.

Note: See TracTickets for help on using tickets.