Opened 10 months ago

Closed 4 months ago

#5449 closed defect (fixed)

bugs found by sanitizers

Reported by: fdupont Owned by: fdupont
Priority: medium Milestone: Kea1.4-final
Component: tests Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I configured, built and run make check with CXX sets to g++ --std=c++11 -fsanitize=undefined on macOS high sierra with Xcode 9.2 (last version). It reported some bugs before losing the race in CtrlChannelDhcpv4SrvTest.concurrentConnections and crashing...

Subtickets

Change History (9)

comment:1 Changed 10 months ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

comment:2 Changed 9 months ago by tomek

  • Component changed from Unclassified to tests
  • Milestone changed from Kea-proposed to Kea1.4-final
  • Priority changed from medium to low

comment:3 Changed 9 months ago by fdupont

  • Summary changed from bugs found by undefined sanitizer to bugs found by sanitizer

Tried leak sanitizer on Fedora 27. Found (and fixed) a trivial (not finalized cleanup so not called when something throws) leak in the eval library.

comment:4 Changed 9 months ago by fdupont

  • Summary changed from bugs found by sanitizer to bugs found by sanitizers

comment:5 Changed 4 months ago by tomek

  • Priority changed from low to medium

comment:6 Changed 4 months ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from accepted to reviewing

Added lgtm reported missing & in catch.
Found and fixed a new issue.
If nobody wants to run sanitizers on another platform (Apple clang is limited) it is ready for review.

comment:7 Changed 4 months ago by tomek

  • Owner changed from UnAssigned to tomek

comment:8 Changed 4 months ago by tomek

  • Owner changed from tomek to fdupont

Reviewed and tested your changes. They look good. Code compiles and unit-tests pass on Ubuntu 17.10 x64.

I experienced some compiler warnings about explict exception types specified being deprecated in C++11. I have removed those. Please pull and review. If you're ok with them, please merge.

comment:9 Changed 4 months ago by fdupont

  • Resolution set to fixed
  • Status changed from reviewing to closed

In fact explicit exception types were already removed... It gives an easy to fix conflict I used to update the copyright year.
Merged, closing.

Note: See TracTickets for help on using tickets.