Opened 8 months ago

Closed 5 weeks ago

#5427 closed defect (complete)

Add hooks library installation instructions to main Kea admin guide

Reported by: tmark Owned by: tomek
Priority: medium Milestone: Kea1.4
Component: documentation Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

We should add "How to install and build" subsection to the Hooks section in the main Kea admin guide. (see <premium>/INSTALL).

Subtickets

Change History (11)

comment:1 Changed 6 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4

Accepting in 1.4 as discussed on Kea call today.

comment:2 Changed 3 months ago by tobi

  • Owner set to tobi
  • Status changed from new to accepted

comment:3 Changed 3 months ago by tobi

I don't understand this "see <premium>/INSTALL", any help?.

comment:4 follow-up: Changed 3 months ago by fdupont

In the premium submodule there is a file named INSTALL which is when you follow the KeaPremium instructions from the private ISC wiki is in the directory where the submodule was cloned, by default premium.
If you'd like someone can attach it to the ticket.

comment:5 in reply to: ↑ 4 Changed 3 months ago by tobi

Replying to fdupont:

In the premium submodule there is a file named INSTALL which is when you follow the KeaPremium instructions from the private ISC wiki is in the directory where the submodule was cloned, by default premium.
If you'd like someone can attach it to the ticket.

Yah, i like to have a look at.

comment:6 Changed 2 months ago by tobi

I have created a PR for this.

If <premium>/INSTALL dictates adding more/anything other fix, then someone could attach it to this ticket.

comment:7 Changed 5 weeks ago by tomek

  • Owner changed from tobi to tomek
  • Status changed from accepted to assigned

comment:8 Changed 5 weeks ago by tomek

  • Owner changed from tomek to Unassigned
  • Status changed from assigned to reviewing

The code is now available for review. Please see new section 14.2 "Installing Hook packages".

Note: this change describes behavior added in #5619.

comment:9 Changed 5 weeks ago by tmark

  • Owner changed from Unassigned to tmark

comment:10 Changed 5 weeks ago by tmark

  • Owner changed from tmark to tomek

I fixed a wrong kea version number and added a paragraph on where the libs get installed.
The KB article you cite looks a bit out of date. Not sure if we need a ticket to update it
the article or maybe you don't need to cite it.

I did not test the actual steps as 5619 isn't merged yet. This needs a ChangeLog? too.

Might be handy if config.report emitted the value of libs dir and the ilk.

Last edited 5 weeks ago by tmark (previous) (diff)

comment:11 Changed 5 weeks ago by tomek

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks for the review. Hooks directory is now printed. The changes are merged.

Closing.

Note: See TracTickets for help on using tickets.