Opened 12 months ago

Closed 4 months ago

#5409 closed defect (fixed)

INSTALL file should be improved

Reported by: tomek Owned by: tmark
Priority: medium Milestone: Kea1.4-final
Component: documentation Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The INSTALL file in Kea root directory is rather basic and should be improved.

There are some grammatical errors, e.g. "To then build from source:"

Subtickets

Change History (8)

comment:1 Changed 10 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4

comment:2 Changed 10 months ago by tomek

  • Milestone changed from Kea1.4 to Kea1.4-final

comment:3 Changed 5 months ago by tomek

  • Priority changed from very low to medium

comment:4 Changed 4 months ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:5 Changed 4 months ago by tmark

  • Owner changed from tmark to 5409
  • Status changed from assigned to reviewing

Improved it a bit. Ready for review.

comment:6 Changed 4 months ago by tmark

  • Owner changed from 5409 to UnAssigned

comment:7 follow-up: Changed 4 months ago by tomek

  • Owner changed from UnAssigned to tmark

Reviewed. Let me just say this ticket is my favorite type of review.

Anyway, the changes look good. I tweaked two minor things: added that autoreconf is also needed when building with premium hook packages and that make install will likely need sudo.

Please pull and review. If it looks ok, go ahead and merge. If it looks broken beyond repair, merge it anyway. It's code freeze day. What could possibly go wrong?

comment:8 in reply to: ↑ 7 Changed 4 months ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

Replying to tomek:

Reviewed. Let me just say this ticket is my favorite type of review.

Thank you! I strive to make my changes clear, concise and easy to digest!

Anyway, the changes look good. I tweaked two minor things: added that autoreconf is also needed when building with premium hook packages and that make install will likely need sudo.

Good catch on the premium thing.

Please pull and review. If it looks ok, go ahead and merge. If it looks broken beyond repair, merge it anyway. It's code freeze day. What could possibly go wrong?

Merged with git# 6de6024c96282e82a68f4b6651999051f8ccdd72

Figured we could skip a ChangeLog? for this.

Note: See TracTickets for help on using tickets.