Opened 9 months ago

Closed 8 days ago

#5378 closed defect (fixed)

global parameters are not shown via API

Reported by: itay_r Owned by: tmark
Priority: medium Milestone: Kea1.4-final
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

1) global parameters (timers) that may influence on subnets are not shown via API at the global configuration,
they are shown on the subnet level only.

2) there is no indication under a subnet that a parameter came locally or from the global config.

Subtickets

Change History (11)

comment:1 Changed 9 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.4

As discussed on 2017-10-05 call, moving this to 1.4.

comment:2 Changed 9 months ago by fdupont

I looked at the subnet command hook: it uses an empty global scope, add all defaults (from simple parser code) to it and derives parameters. So the defaults come from the code, not from the current config: another reason to keep the global parameters after derivation/parsing/etc.
IMHO either we should create another ticket or submit again this ticket to triage (and bump its priority).

comment:3 Changed 7 weeks ago by tomek

  • Milestone changed from Kea1.4 to Kea1.4-final

As discussed on 2018-04-26 call, moving low and some med priority tickets to 1.4-final.

comment:4 Changed 3 weeks ago by tomek

  • Priority changed from low to medium

comment:5 Changed 2 weeks ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:6 Changed 8 days ago by tmark

Main repo:

Added storage and maintenance of configured globals to SrvConfig?
Modified server configuration parsing to store globals

ChangeLog?

14xx.   [bug]       tmark
    kea-dhcp4 and kea-dhcp6 now retain and emit global, scalar
    parameters specified in their configuration.
    (Trac #5378, git TBD)

Premium repo:

Modified Subnet Cmds hooks lib to add server's globals when adding networks and subnets

ChangeLog?

xxxx.   [bug]       tmark
    Networks and subnets added via Subnet Cmds hooks library now
    properly inherit global parameters specified at the server
    level.
    (Trac #5378, git TBD)

Ticket is ready for review.

comment:7 Changed 8 days ago by tmark

  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

comment:8 Changed 8 days ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:9 Changed 8 days ago by fdupont

Argh, my comment eaten by trac?

I added a line break and fixed copyright of core tests so please pull.
I reviewed core and premium codes, and tested them so please merge with the ChangeLog entry.

comment:10 Changed 8 days ago by fdupont

  • Owner changed from fdupont to tmark

Third attempt to change the owner...

comment:11 Changed 8 days ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

Changes merged to main repo with git# 4d05122f03d00b10a888c768fe1725cae9d6aea6
ChangeLog? entry 1423 added.

Changes merged to premium repo with git# f31bbaccc96ea901b34b8e18e98c0f99fb0872ec
ChangeLog? entry 58 added.

Ticket is complete.

Note: See TracTickets for help on using tickets.