Opened 16 months ago

Closed 3 months ago

#5294 closed enhancement (wontfix)

improve DHCPv4 server code coverage

Reported by: fdupont Owned by:
Priority: low Milestone: Kea1.4-final
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets: #5259
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

1- ctrl_dhcp4_srv.cc: should either make loadConfigFile returning an error or add a "sanity check" comment if it should not happen, same for bad parse error (very likely "sanity check"), same for "not running" and for "hooks libs reload fail". Note it seems some control channel command handlers are partially unreached?
2- dhcp4_lexer.ll: test "raw", "readonly", "connect-timeout", "interface-id" (which is really unused), "rapid-commit" (unused too), "tcp" (see d2 ticket), \u escapes with lower and upper letters.
3- dhcp4_parser.yy: same than 2 with in addition replace-client-name with a boolean
4- dhcp4_srv.cc: a few "sanity check" missing comments, copy relay info (but this case is not supported by current 4o6 code), skip in subnet-select hook, 4o6 subnet-select, srvidToString, "packet drop 0003"
5- dhcp4to6_ipc.cc: 2 "sanity check", skip from hook.
6- json_config_parser.cc: add a test for "host-database"
7- main.cc: usage (?), -V, -W, -p
8- parser_context.cc: same than d2 or agent.

Conclusion: missing tests clearly in the scope of #5259.

Subtickets

Change History (4)

comment:1 Changed 15 months ago by tomek

  • Milestone changed from Kea-proposed to Kea 1.4

As discussed on 2017-06-28 call, we accepted one ticket (for libdhcpsrv and parsers) and pushed other tickets away. We will reevaluate when next milestone starts.

comment:2 Changed 12 months ago by tomek

  • Milestone changed from Kea 1.4 to Kea1.4

Milestone renamed

comment:3 Changed 6 months ago by tomek

  • Milestone changed from Kea1.4 to Kea1.4-final

We certainly won't have time for unit-tests improvements in 1.4, moving to final.

comment:4 Changed 3 months ago by tomek

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.