Opened 16 months ago

Closed 3 months ago

#5293 closed enhancement (wontfix)

improve d2 code coverage

Reported by: fdupont Owned by:
Priority: low Milestone: Kea1.4-final
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets: #5259
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

1- d2_cfg_mgr.cc: a few "sanity check" missing comments, D2CfgContext copy constructor is not reached (so add a test or remove it? Note the clone method of the header file is unreached too).
2- d2_config.h: DScalarContext unreached
3- d2_config.cc: some "sanity check" missing comments, some D2Params unreached methods so clearly some missing tests.
4- d2_controller.cc: missing KEA_FROM_BUILD and -V
5- d2_lexer.ll: missing out-of-scope "tcp" test (other unreached lines are tested in other servers).
6- d2_queue_mgr.cc: a few "sanity check" missing comments which give unused exceptions in the header file.
7- d2_queue_mgr.cc: unmatched reverse server needs a test
8- nc_add.cc: unreached (perhaps unreachable) default/error cases. IMHO there is nothing to do...
9- nc_remove.cc: same than 8
10- nc_remove.cc: a few "sanity check" missing comments.
11- parser_context.cc: same than for agent parser_context.cc.

Conclusion: address 1- copy/clone, 3- D2Params, 5 and 7 at low priority and remaining at very low.

Subtickets

Change History (4)

comment:1 Changed 15 months ago by tomek

  • Milestone changed from Kea-proposed to Kea 1.4

As discussed on 2017-06-28 call, we accepted one ticket (for libdhcpsrv and parsers) and pushed other tickets away. We will reevaluate when next milestone starts.

comment:2 Changed 12 months ago by tomek

  • Milestone changed from Kea 1.4 to Kea1.4

Milestone renamed

comment:3 Changed 6 months ago by tomek

  • Milestone changed from Kea1.4 to Kea1.4-final

We certainly won't have time for unit-tests improvements in 1.4, moving to final.

comment:4 Changed 3 months ago by tomek

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.