Opened 17 months ago

Last modified 3 months ago

#5259 accepted enhancement

Extend DHCP parsers unit tests

Reported by: stephen Owned by: fdupont
Priority: low Milestone: Outstanding Tasks
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

#5258 was a crash caused by trivially incorrect code. However on fixing it, it became apparent that not all the DHCP parsers in src/lib/dhcpsrv/parsers/dhcp_parsers.cc are covered by sufficient unit tests.

This ticket is for the extension of those tests.

Subtickets

#5291: improve libeval code coverageclosed
#5292: improve agent code coverageclosed
#5293: improve d2 code coverageclosed
#5294: improve DHCPv4 server code coverageclosed
#5295: improve DHCPv6 code coverageclosed
#5296: improve libcc code coverageclosed
#5297: improve server parsers code coverageclosedfdupont
#5298: improve libprocess code coverageclosed

Change History (15)

comment:1 Changed 16 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.3
  • Priority changed from medium to low

As decided on 2017-05-18 call, moving to 1.3 as low.

comment:2 Changed 16 months ago by fdupont

As I noted on the call minutes, I propose to use coverage reports to identify untested code and more important dead code (i.e., code which can't be run so tested but is not identified as this. Usually this comes a programming error or from missing cleanup after rewrite).

comment:3 Changed 16 months ago by fdupont

Add a subticket #5291.

comment:4 Changed 16 months ago by fdupont

Add a subticket #5292.

comment:5 Changed 16 months ago by fdupont

Add a subticket #5293.

comment:6 Changed 16 months ago by fdupont

Add a subticket #5294.

comment:7 Changed 16 months ago by fdupont

Add a subticket #5295.

comment:8 Changed 16 months ago by fdupont

Add a subticket #5296.

comment:9 Changed 16 months ago by fdupont

Add a subticket #5297.

comment:10 Changed 16 months ago by fdupont

Add a subticket #5298.

comment:11 Changed 12 months ago by tomek

  • Milestone changed from Kea1.3 to Kea1.3-final

As discussed on 2017-09-14, the time is running out before beta deadline, so many decided to move many tickets to 1.3 final and 1.4.

comment:12 Changed 11 months ago by fdupont

  • Owner set to fdupont
  • Status changed from new to accepted

Only one ticket is still in 1.3 final so I am addressing it and when it will be merged I propose to move this ticket to 1.4.

comment:13 Changed 11 months ago by fdupont

  • Milestone changed from Kea1.3-final to Kea1.4

#5297, the only remaining child in 1.3-final, was closed so moving this meta ticket to 1.4.

comment:14 Changed 5 months ago by tomek

  • Milestone changed from Kea1.4 to Kea1.4-final

As discussed on 2018-04-26 call, moving low and some med priority tickets to 1.4-final.

comment:15 Changed 3 months ago by tomek

  • Milestone changed from Kea1.4-final to Outstanding Tasks

As discussed on 2018-06-20 call.

Note: See TracTickets for help on using tickets.