Opened 8 months ago

Closed 7 months ago

#5213 closed enhancement (complete)

config-reload command

Reported by: tomek Owned by: tomek
Priority: high Milestone: Kea1.2-final
Component: management API Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 11
Total Hours: 11 Internal?: no

Description

We have the capability to reload existing config. It should be exposed via command channel.

Subtickets

Change History (7)

comment:1 Changed 8 months ago by tomek

  • Milestone changed from Kea1.2 to Kea1.2-final

comment:2 Changed 7 months ago by tomek

  • Owner set to tomek
  • Status changed from new to assigned

comment:3 Changed 7 months ago by tomek

  • Priority changed from medium to high

comment:4 Changed 7 months ago by tomek

  • Add Hours to Ticket changed from 0 to 11
  • Owner changed from tomek to Unassigned
  • Status changed from assigned to reviewing
  • Total Hours changed from 0 to 11

The code is now ready for review. In addition to the config-reload command, it also covers rename of set-config to config-set.

Proposed ChangeLog? entry:

12XX.	[func]		tomek
	config-reload command implemented. It allows Kea DHCPv4 and DHCPv6
	servers to reload its original configuration file. Also,
	set-config command renamed to config-set.
	(Trac #5213, git tbd)

comment:5 Changed 7 months ago by fdupont

  • Owner changed from Unassigned to fdupont

comment:6 Changed 7 months ago by fdupont

  • Owner changed from fdupont to tomek

Perhaps we should mention "config-write" in the "config-reload" warning?

I found some left occurrences of "set-config". I fixed them (so please pull) and take the occasion to rename handlers

In theory you should remove temporary test files (e.g. test7.json) in the fixture destructor but please don't change the code just for this.

I pushed some cosmetic fixes but the code is fine and works well on my dev box.

About the ChangeLog IMHO it is "was renamed". Ready for merging.

comment:7 Changed 7 months ago by tomek

  • Resolution set to complete
  • Status changed from reviewing to closed

Thanks for the review and your fixes. They look good.

Code merged, closing ticket.

Note: See TracTickets for help on using tickets.