Opened 18 months ago

Closed 4 months ago

#5205 closed defect (fixed)

Add more detailed logging into the libkea-http library

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.4-final
Component: agent Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

While system testing Control Agent, I found that often the logging statements in (both) Control Agent and libkea-http are far from giving enough details about the issues. For example, when the command received from the client fails the reason for the failure should be logged. This would help diagnosing the potential problem with the system or the client.

Subtickets

Change History (11)

comment:1 Changed 17 months ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.3

Per team meeting Apr 13, place in 1.3 milestone

comment:2 Changed 16 months ago by tomek

  • Priority changed from medium to low

comment:3 Changed 15 months ago by tomek

  • Milestone changed from Kea1.3 to Kea 1.4

After discussing with Stephen, pushed back several tickets to lower the workload in 1.3.

comment:4 Changed 12 months ago by tomek

  • Milestone changed from Kea 1.4 to Kea1.4

Milestone renamed

comment:5 Changed 5 months ago by tomek

  • Milestone changed from Kea1.4 to Kea1.4-final

As discussed on 2018-04-26 call, moving low and some med priority tickets to 1.4-final.

comment:6 Changed 4 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:7 Changed 4 months ago by tomek

  • Priority changed from low to medium

comment:8 Changed 4 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I have improved logging in the HTTP library. I also updated the Control Agent CommandMgr? to return a hint to the user which does not include the "service" parameter and when the command is not supported by the CA, that the user should include the "service" parameter to forward the command to one or more servers. That should help some users who often forget (or don't know) that this parameter must be included.

I don't know if that requires changelog entry as it mostly just improves logging.

comment:9 Changed 4 months ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:10 Changed 4 months ago by fdupont

  • Owner changed from fdupont to marcin

As we got user complains I am afraid a ChangeLog entry is needed.
Reading the code it is fine (even ispell likes it!) and it passed make check on my macOS.
IMHO ready to be merged.

comment:11 Changed 4 months ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit fd0bec610c89084d5a5d43ef032c9875c3e6ad46 and provided the ChangeLog entry as well.

Note: See TracTickets for help on using tickets.