Opened 17 months ago

Closed 2 months ago

#5115 closed defect (fixed)

perfdhcp command options unnecessarily restrictive

Reported by: raybellis Owned by: tmark
Priority: medium Milestone: Kea1.4
Component: perfdhcp Version: git
Keywords: perfdhcp Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Low
Sub-Project: DHCP Feature Depending on Ticket: perflab integration
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The -D<max-drop>, -n<num-request>, -p<test-period> and -t<report> options to perfdhcp all require use of the -r<rate> option.

I can't see any good reason for this restriction, nor any actual interdependency within the code.

Subtickets

Attachments (1)

perfdhcp.diff (2.2 KB) - added by raybellis 17 months ago.

Download all attachments as: .zip

Change History (11)

Changed 17 months ago by raybellis

comment:1 Changed 17 months ago by tomek

  • Milestone changed from Kea-proposed to Kea1.2
  • Priority changed from medium to low

As discussed on 2016-01-26 call, moving to 1.2 low.

comment:2 Changed 15 months ago by tomek

  • Milestone changed from Kea1.2 to Kea1.2-final

Code freeze for 1.2-beta. Moving all remaining open tickets to 1.2-final.

comment:3 Changed 14 months ago by tomek

  • Milestone changed from Kea1.2-final to Outstanding Tasks

As discussed on 2017-04-13 call, moving to outstanding.

comment:4 Changed 4 months ago by tomek

  • Milestone changed from Outstanding Tasks to Kea1.4
  • Priority changed from low to medium

Given the recent sudden interest in performance measurements, moving this ticket to 1.4 as medium. The patch is there, so review should be quick.

comment:5 Changed 3 months ago by tmark

  • Owner set to tmark
  • Status changed from new to assigned

comment:6 Changed 2 months ago by tmark

  • Owner changed from tmark to UnAssigned
  • Status changed from assigned to reviewing

Removed command line checks where appropriate and updated unit tests and doc.
Ready for review.

ChangeLog:

13xx.   [func]      tmark
    perfdhcp no longer requires -r (rate) be specified in order to use 
    -D<max-drop>, -n<num-request>, -p<test-period> and -t<report> options.
    (Trac #5115, git TBD)

comment:7 Changed 2 months ago by tomek

  • Owner changed from UnAssigned to tomek

comment:8 follow-up: Changed 2 months ago by tomek

  • Owner changed from tomek to tmark

Your changes are good, but please remove the code in command_options_unittest.cc rather than ifdef it.

Code builds and unit-tests pass on mac os 10.12.6.

comment:9 in reply to: ↑ 8 Changed 2 months ago by tmark

Replying to tomek:

Your changes are good, but please remove the code in command_options_unittest.cc rather than ifdef it.

Actually I had already done so but forgot to push it.

Code builds and unit-tests pass on mac os 10.12.6.

SHIP IT!

comment:10 Changed 2 months ago by tmark

  • Resolution set to fixed
  • Status changed from reviewing to closed

Changes merged with git #c3ba89c56882cac1080899ad201f0c02056eef38
Added ChangeLog? entry 1387.

ticket is complete.

Note: See TracTickets for help on using tickets.