Opened 11 months ago

Closed 4 months ago

Last modified 2 months ago

#5108 closed task (complete)

Update keactrl to support kea-ctrl-agent startup, shutdown and reconfiguration

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.3 beta
Component: scripts Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: Mozilla Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 2
Total Hours: 10 Internal?: no

Description

The kea-ctrl-agent is a new daemon which should be supported by the keactrl, just like other daemons. See http://kea.isc.org/wiki/ControlAPIDesign

Subtickets

Change History (13)

comment:1 Changed 9 months ago by tomek

  • Sub-Project changed from DHCP to Mozilla

comment:2 Changed 9 months ago by hschempf

  • Milestone changed from Kea1.2 to Kea1.2-final

comment:3 Changed 7 months ago by tomek

  • Milestone changed from Kea1.2-final to Kea1.3

As discussed on 2017-04-13 Kea call, moving to 1.3.

comment:4 Changed 6 months ago by tomek

  • Component changed from Unclassified to scripts

comment:5 Changed 4 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:6 Changed 4 months ago by marcin

  • Add Hours to Ticket changed from 0 to 8
  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing
  • Total Hours changed from 0 to 8

I made the following updates:

  • CA and other servers can have configuration combined in a single file,
  • keactrl.conf now has ctrl_agent and ctrl_agent_srv variables,
  • keactrl supports CA start, stop, reload and status
  • keactrl man page updated,
  • keactrl section in User's Guide updated

I haven't regenerated lexer and parser files but I am planning to do it during merge on the master branch.

The following is the ChangeLog proposal:

12XX.	[func]		marcin
	It is now possible to manage Control Agent with keactrl.
	(Trac #5108, git cafe)

comment:7 Changed 4 months ago by tmark

  • Owner changed from UnAssigned to tmark

comment:8 follow-up: Changed 4 months ago by tmark

  • Owner changed from tmark to marcin

Changes are fine with one exception:

You need to update the parsers and commit them. keactrl unit tests fall over
because the other servers' parsers don't recognize "Control-agent" keyword.

I'm wondering if parser unit tests for dhcp4, dhcp6, and d2 need to updated to verify they can parse Control-agent?

comment:9 in reply to: ↑ 8 Changed 4 months ago by fdupont

Replying to tmark:

Changes are fine with one exception:

You need to update the parsers and commit them. keactrl unit tests fall over
because the other servers' parsers don't recognize "Control-agent" keyword.

=> docs.isc.org:~fdupont/bin ... If you are not in a hurry I can do it (later, I need to get lunch, go downtown to edit my train ticket, etc).

I'm wondering if parser unit tests for dhcp4, dhcp6, and d2 need to updated to verify they can parse Control-agent?

=> as far as I can remember this is done in one line unit test. So IMHO it should be done.

comment:10 Changed 4 months ago by marcin

  • Owner changed from marcin to tmark

I have updated unit tests as suggested. The parser files I am planning to regenerate after merge.

comment:11 Changed 4 months ago by tmark

  • Add Hours to Ticket changed from 8 to 2
  • Owner changed from tmark to marcin
  • Total Hours changed from 8 to 10

Tests look good, thanks. Please merge.

comment:12 Changed 4 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged with commit 53ba9f8197a25abd2c52ee3f5e95bc4e4be0241f

comment:13 Changed 2 months ago by vicky

  • Milestone changed from Kea1.3 to Kea1.3 beta

Milestone renamed

Note: See TracTickets for help on using tickets.