#5075 closed task (complete)

Create stub Control Agent

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.2
Component: remote-management Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See http://kea.isc.org/wiki/ControlAPIDesign

The new Control Agent process should be based (should derive from) on the DController class. The stub implementation should provide appropriate make files, create appropriate directories structure and provide an app that does nothing besides initializing logging, signals, and terminating.

Subtickets

Change History (10)

comment:1 Changed 12 months ago by marcin

  • Milestone changed from Kea-proposed to Kea1.2

comment:2 Changed 12 months ago by marcin

  • Component changed from management API to remote-management

comment:3 Changed 12 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:4 Changed 12 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I used the CPL (libkea-process) to create a new application kea-ctrl-agent, which will implement the function of a Control Agent. This stub implementation and the unit tests are "copied" from the D2. It doesn't do a lot. It can simply be started and stopped.

Proposed ChangeLog entry:

1193.   [func]         marcin
	Created kea-ctrl-agent. This application currently doesn't
	do anything. Future tickets will add REST API to allow for
	managing Kea services.
        (Trac #5075, git abcd)

comment:5 Changed 11 months ago by fdupont

  • Owner changed from UnAssigned to fdupont

comment:6 Changed 11 months ago by fdupont

This applies to the process library too but ZERO_POSITION() was created to avoid to create at each time the default position.

I fixed a few spelling errors so please pull.

IMHO boost/pointer_cast.hpp should be included by any code using boost::dynamic_pointer_cast even compilers don't seem to complain.

kea-ctrl-agent.xml copyright years are obviously wrong (IMHO they should be 2016)

I don't like the "as JSON strings". IMHO "in JSON text format" is better but perhaps someone has even better proposal(s)?

The code seems OK, tests passed on my box (and Jenkins dev build farm seems to not be available?)

comment:7 Changed 11 months ago by fdupont

  • Owner changed from fdupont to marcin

comment:8 Changed 11 months ago by marcin

  • Owner changed from marcin to fdupont

I addressed the review comments. I also corrected typos in the Makefile.am.

comment:9 Changed 11 months ago by fdupont

  • Owner changed from fdupont to marcin

Ready to merge.

comment:10 Changed 11 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged with commit 1ec7586da5ae1474b52d5a395fb80ee37d6d568e

Note: See TracTickets for help on using tickets.