#5074 closed task (complete)

Move DController class to a common library so as it can be reused by the Control Agent

Reported by: marcin Owned by: marcin
Priority: medium Milestone: Kea1.2
Component: management API Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

See: http://kea.isc.org/wiki/ControlAPIDesign

Kea Control Agent is a new process which receives and forwards control commands to separate processes. The new process should reuse the classes provided by D2. Specifically, it should reuse DControler class but also classes it depends on, e.g. IOSignal etc.

Subtickets

Change History (7)

comment:1 Changed 12 months ago by marcin

  • Milestone changed from Kea-proposed to Kea1.2

comment:2 Changed 12 months ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 12 months ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

I created the libkea-process library and moved the CPL classes from D2 to this new class. This required creation of a new logger and changing ids of some log messages. It also required updates to the doxygen stuff, but I tried to keep the changes minimal.

11XX.   [build]         marcin
        Created libkea-process library and moved the Controllable
        Process Layer (CPL) from D2 to this new library.
        (Trac #5074, git abcd)

comment:4 Changed 12 months ago by tmark

  • Owner changed from UnAssigned to tmark

comment:5 Changed 12 months ago by tmark

I am pleased that you've decided to use CPL. Validates my effort in creating it.

Overall the move looks fine. Everything builds and tests pass. Just a couple of minor things:

  1. You did not move DScalarContext into libkea-process. One could argue this either way, and I suppose unless you see direct need you might not move it. Still, it is really part of the CPL, though neglected in the doc.
  1. src/lib/process/libprocess.dox - I took the liberty of rewording the intro just a little.

Note I removed the reference to the D2 design doc because it actually does not discuss the CPL.

Ready to merge.

comment:6 Changed 12 months ago by tmark

  • Owner changed from tmark to marcin

comment:7 Changed 12 months ago by marcin

  • Resolution set to complete
  • Status changed from reviewing to closed

Merged with commit 16be7fe34c1c9c4820d9aaa7b51695ad7820508a

Note: See TracTickets for help on using tickets.