Opened 23 months ago

Last modified 22 months ago

#4251 new defect

configure does not abort when --with-gtest fails to find google test

Reported by: tomek Owned by:
Priority: medium Milestone: Outstanding Tasks
Component: build system Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

I have gtest 1.7.0 compiled from sources. By mistake, I used --with-gtest instead of --with-gtest-source. The configure script printed a warning (that was not spotted) and compilation continued until first attempt of unit-test compilation, which failed due to missing libraries.

The configure script should abort. Better yet, we should merge --with-gtest and --with-gtest-source options.

Subtickets

Change History (2)

comment:1 Changed 23 months ago by fdupont

IMHO we should phase out the --with-gtest in favor of --with-gtest-source because:

  • some platforms don't offer a gtest package
  • the official gtest documentation strongly recommends to not package it
  • only the last sources are c++11 compliant

comment:2 Changed 22 months ago by tomek

  • Milestone changed from Kea-proposed to Outstanding Tasks

Moving all bugs to outstanding, we'll triage them with other defects.

Note: See TracTickets for help on using tickets.