Opened 3 years ago

Last modified 8 months ago

#4068 reviewing defect

SIGCHLD must not be ignored

Reported by: fdupont Owned by: UnAssigned
Priority: low Milestone: Outstanding Tasks
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by fdupont)

in signal_set.{h,cc}:

    /// Prior to invoking the handler, it sets signal action for the
    /// given signal to SIG_IGN which prevents any repeat signal
    /// occurrences from queuing while the handler is executing.  Upon
    /// completion of the handler, the signal action is restored which
    /// re-enables receipt and handling of the signal.

This should not be applied to SIGCHLD as ignoring it has a special meaning we don't want.

Subtickets

Change History (6)

comment:1 Changed 3 years ago by hschempf

  • Milestone changed from Kea-proposed to DHCP Outstanding Tasks

per team meeting sept 23, move to outstanding

comment:2 Changed 3 years ago by fdupont

Note we can postpone the fix of this bug if we can assume there is only at most one child process... (true in the current code).

comment:3 Changed 3 years ago by fdupont

  • Owner changed from fdupont to UnAssigned
  • Status changed from new to reviewing

Ready for review (low priority, cf previous comment).

comment:4 Changed 3 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

comment:5 Changed 11 months ago by fdupont

  • Description modified (diff)
  • Milestone changed from Outstanding Tasks to Kea-proposed

Still a bug to fix one day...

comment:6 Changed 8 months ago by tomek

  • Milestone changed from Kea-proposed to Outstanding Tasks

As discussed on 2018-01-11 call, this is likely a bug, but the proposed fix didn't solve the customer's problem. Also, this is not an issue that bothers any specific deployments right now, but we'd like to improve the code one day. As such, moving to outstanding.

Note: See TracTickets for help on using tickets.