Opened 2 years ago

Last modified 2 years ago

#4008 new defect

Remove unused code

Reported by: stephen Owned by:
Priority: low Milestone: Outstanding Tasks
Component: Unclassified Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

When Kea was separated from BIND 10, a lot of unused code was removed, but not all: this ticket covers the removal of that code. Code to be removed includes:

  • All of src/lib/util/threads
  • Most code in src/lib/asiolink
  • Components of src/lib/dns unused by dhcp-ddns (i.e most of the RR-specific code, masterfile loader, zone checker etc.)

Subtickets

Change History (10)

comment:1 Changed 2 years ago by fdupont

Not sure for src/lib/util/threads: I believe it is used by src/lib/log.

comment:2 Changed 2 years ago by fdupont

I confirm: src/lib/log uses Mutex objects which are defined in src/lib/util/threads/sync.*. BTW IMHO it should not so I'll open a specific ticket about this.

comment:3 Changed 2 years ago by fdupont

Removed src/lib/util/threads from the unused/to-be-removed code list.

BTW we should decide the order between the asiolink cleanup and #4009 (aka using boost asio). IMHO cleanup should be first.

comment:4 Changed 2 years ago by fdupont

It seems src/lib/asiodns is a better candidate (than asiolink) for a massive cleanup (only io_fetch and logger are used).
I am creating an asiodns and a header cleanup tickets.
(#4028 and #4029).

comment:5 Changed 2 years ago by fdupont

#4028 and (then) #4029 ready for review.

comment:6 Changed 2 years ago by fdupont

Creating a ticket for asiolink cleanup (includes #4029 which itself includes #4028). Number #4031.

comment:7 Changed 2 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.0

comment:8 Changed 2 years ago by fdupont

#4031 and its companions were merged. Only the last item (dns++ cleanup) remains.

comment:9 Changed 2 years ago by hschempf

  • Milestone changed from Kea1.0 to DHCP Outstanding Tasks

comment:10 Changed 2 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

Note: See TracTickets for help on using tickets.