Opened 3 years ago

Last modified 2 years ago

#3774 new defect

Clean up Dhcp6Srv handling/use of context class instances

Reported by: tmark Owned by:
Priority: medium Milestone: Outstanding Tasks
Component: dhcp6 Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

Citing review comments from #3689:

"> When creating a new context could you just use the copy constructor and then explicitly set the values that differ between the orig_ctx and the ctx? I think it would be clearer as to what has changed between the two or what new fields are being set.

Could callout_handle be set for the original context in the createContext method?

I really dislike the mixed use of ClientContext6. Part of it is initialized in the createContext. Then, the whole thing is copied to the new context to add new parameters specific to the lease assignment to the particular IAs. Maybe we should have a base context that holds the specific information about the client, subnet etc. There could be a per-IA context which derives from the base context and captures all additional information. Do you think this makes sense? Should we open a ticket for this?

extendIA_NA: The same comment as above about use of copy constructor for creating a new context.

Regarding all of the above, I agree but I think we should create a specific ticket to clean it up. To do it properly will take some careful thought (i.e. design)."


Subtickets

Change History (4)

comment:1 Changed 3 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea1.0

comment:2 Changed 2 years ago by marcin

  • Milestone changed from Kea1.0 to Kea1.1

Deferring from 1.0 as per 1.0 tickets scrub.

comment:3 Changed 2 years ago by tomek

  • Milestone changed from Kea1.1 to DHCP Outstanding Tasks

comment:4 Changed 2 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

Note: See TracTickets for help on using tickets.