Opened 3 years ago

Closed 3 years ago

#3538 closed defect (fixed)

After renaming the parameter "pool" to "pools" the default kea.conf must be updated.

Reported by: marcin Owned by: marcin
Priority: high Milestone: Kea0.9.1beta
Component: dhcp4 Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: Medium
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description

The default kea.conf file must be updated to use "pools" instead of "pool" parameter in the configuration.

This is user-visible defect.

Subtickets

Change History (13)

comment:1 Changed 3 years ago by tomek

  • Milestone changed from Kea-proposed to Kea0.9.1
  • Priority changed from medium to high

comment:2 Changed 3 years ago by marcin

  • Owner set to marcin
  • Status changed from new to accepted

comment:3 Changed 3 years ago by marcin

This is a straight forward change which modifies single line of the kea.conf.in file.

Proposed ChangeLog entry:

XYZ.	[bug]		marcin
	Corrected the definition of the example DHCPv4 address pool in the
	default	kea.conf file.
	(Trac #3538, git abc)

comment:4 Changed 3 years ago by marcin

  • Owner changed from marcin to UnAssigned
  • Status changed from accepted to reviewing

comment:5 Changed 3 years ago by marcin

  • Owner changed from UnAssigned to marcin

I forgot to apply the fix to the DHCPv6 server config. So, recalling this ticket.

comment:6 Changed 3 years ago by marcin

  • Owner changed from marcin to UnAssigned

Fixed V6 pool definitions too. So, putting back to review.

comment:7 Changed 3 years ago by jreed

Can we add some tests that use these example configurations?

Last edited 3 years ago by jreed (previous) (diff)

comment:8 Changed 3 years ago by jreed

By the way I have related ticket #3535 as these configurations should be installed differently

comment:9 Changed 3 years ago by tomek

  • Owner changed from UnAssigned to tomek

comment:10 Changed 3 years ago by tomek

Implementing a test that loads examples is trickier than it looks. I tried doing that, but eventually gave up on the idea. There were problems with interface names that are different on various OSes. We can fake that using stub interface implementations, but it is not that trivial anymore.

Another task I was surprised with is to have a portable ability to list files in a directory. There's a nice lib in boost for that, but it requires installing boost libraries. We could implement it in pure C, but that's not something that is elegant in C++ code.

All those problems are solvable, but that requires time. It's better to deliver the fix quickly and implement the tests in a separate ticket. Created #3594 for that purpose.

comment:11 Changed 3 years ago by tomek

  • Owner changed from tomek to marcin

The changes are good, but I propose to update text description of the subnet4 structure. Here's my proposal:

# Below in an example of the simple subnet declaration. Uncomment to
# enable it. This is a list, denoted with [ ], of structures, denoted
# with { }. Each structure describes a single subnet and may have
# several parameters. One of those parameters is "pools" that is
# also a list of structures.

If you agree with this, please apply and merge. If not, let's discuss on jabber and be done with it quickly.

comment:12 Changed 3 years ago by tomek

There's another issue with the kea.conf file (logging directory is broken), but that's to be handled by #3536.

comment:13 Changed 3 years ago by marcin

  • Resolution set to fixed
  • Status changed from reviewing to closed

Merged with commit 8712cc0df77368940d8d3d11811a9ac9504bce12

Note: See TracTickets for help on using tickets.