Opened 4 years ago

Last modified 2 years ago

#3116 new defect

Improve sanity checks for incoming DHCPv4 packets

Reported by: tomek Owned by:
Priority: medium Milestone: Outstanding Tasks
Component: dhcp4 Version: git
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DHCP Feature Depending on Ticket:
Estimated Difficulty: 0 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by marcin)

Dhcpv4Srv::processRequest, processRelease, processDecline, processInform do not call sanityCheck().

With ticket we have to make sure that this doesn't cause any security vulnerabilities. At later time we should fix it, but possibly after 1.0.

Subtickets

Change History (10)

comment:1 Changed 4 years ago by tomek

  • Description modified (diff)

comment:2 Changed 3 years ago by marcin

  • Milestone changed from DHCP Outstanding Tasks to Kea-proposed
  • Version set to git

During the review of #3688 Tom suggested that we include this ticket in 1.0 release. I agree we should consider this,

comment:3 Changed 3 years ago by hschempf

  • Milestone changed from Kea-proposed to Kea0.9.2

comment:4 Changed 3 years ago by hschempf

  • Milestone changed from Kea0.9.2 to Kea1.0

comment:5 Changed 2 years ago by marcin

  • Description modified (diff)

comment:6 Changed 2 years ago by fdupont

BTW I addressed a similar issue on another ticket and to call sanityCheck() in all process*() routines was a part of the solution. So IMHO this ticket is likely a duplicate...

comment:7 Changed 2 years ago by fdupont

Related to #3773 (and #3957 which is likely a duplicate).

comment:8 Changed 2 years ago by tomek

Besides actually using sanityCheck(), also Dhcp4Srv::acceptServerId will require improvement. Please note that it expects the DHO_DHCP_SERVER_IDENTIFIER option to be an instance of OptionCustom?, but the server sends in its responses this option as an instance of Option4AddrLst (see Dhcp4Srv::appendServerID()).

This makes running any tests, especially those that use Dhcp4Client class, impossible to use once the sanity check is enabled.

comment:9 Changed 2 years ago by stephen

  • Milestone changed from Kea1.0 to DHCP Outstanding Tasks

Per Kea planning session in October, moved out of 1.0.

comment:10 Changed 2 years ago by tomek

  • Milestone changed from DHCP Outstanding Tasks to Outstanding Tasks

Milestone renamed

Note: See TracTickets for help on using tickets.