Opened 6 years ago

Closed 6 years ago

#1806 closed task (complete)

support NSEC for empty non-terminal in in-memory (1/2)

Reported by: jinmei Owned by: jelte
Priority: medium Milestone: Sprint-20120515
Component: data source Version:
Keywords: Cc:
CVSS Scoring: Parent Tickets:
Sensitive: no Defect Severity: N/A
Sub-Project: DNS Feature Depending on Ticket: in-memory NSEC
Estimated Difficulty: 3 Add Hours to Ticket: 0
Total Hours: 0 Internal?: no

Description (last modified by jinmei)

We'll update this case InMemoryZoneFinder::find(). it's an empty non
terminal case (and shouldn't be wildcard, but check that)

                if (node_path.getLastComparisonResult().getRelation() ==
                    NameComparisonResult::SUPERDOMAIN) {
                    LOG_DEBUG(logger, DBG_TRACE_DATA, DATASRC_MEM_SUPER_STOP).
                        arg(name);
                    return (createFindResult(NXRRSET, ConstRBNodeRRsetPtr()));
                }

It uses getClosestNSEC() (see #1805) to get the NSEC for the previous
name of the empty name and includes it in the answer. Note that it
shouldn't do this extra work unless DNSSEC is required and the zone is
known to be NSEC-signed (because the cost is not zero).

It depends on #1802, #1803 and #1805. It doesn't need #1804.

REVISED: a revised version of #1805 doesn't need #1803. This task can
be started once the revised version of #1805 is ready.

Subtickets

Change History (10)

comment:1 Changed 6 years ago by jinmei

  • Description modified (diff)

comment:2 Changed 6 years ago by jelte

  • Estimated Difficulty changed from 0 to 3

comment:3 Changed 6 years ago by jelte

  • Milestone changed from New Tasks to Sprint-20120515

comment:4 Changed 6 years ago by jinmei

  • Description modified (diff)

comment:5 Changed 6 years ago by jelte

  • Owner set to jelte
  • Status changed from new to assigned

comment:6 Changed 6 years ago by jelte

  • Owner changed from jelte to UnAssigned
  • Status changed from assigned to reviewing

Ready for review (branched from #1805, and will not be merged until #1803 and #1805 are)

Short note given the original description of this ticket; since the getClosestNSEC() as written in #1805 does the if nsec_signed_ && FIND_DNSSEC check, I just simply call that, whether or not these options are set (should that check be removed in getClosestNSEC, it needs to be added on the calling side)

comment:7 Changed 6 years ago by jelte

Oh. If you happen to pick up this review, you might want to take a look at #1807 as well; I ended up branching from this branch (to reuse the test code), and while making the test code I replaced what I added here (and removed the RR's I added here).

comment:8 Changed 6 years ago by jinmei

  • Owner changed from UnAssigned to jinmei

The total diff for #1806 + #1807 doesn't seem to be big, so I'll review the combined code
at once.

comment:9 Changed 6 years ago by jinmei

  • Owner changed from jinmei to jelte

This branch was reviewed in #1807. Maybe we can simply close this ticket at this point.

comment:10 Changed 6 years ago by jelte

  • Resolution set to complete
  • Status changed from reviewing to closed

Ack, done.

Note: See TracTickets for help on using tickets.